chore: bump grafana-aws-sdk and grafana-plugin-sdk-go #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
njvrzm
force-pushed
the
njvrzm/bump-sdks
branch
from
6e7ab2d
to
7d92194
Compare
njvrzm
force-pushed
the
njvrzm/bump-sdks
branch
from
7d92194
to
bb031e8
Compare
iwysiu
reviewed
Sep 24, 2024
pkg/opensearch/client/client.go
Outdated
| @@ -54,7 +55,11 @@ func NewDatasourceHttpClient(ctx context.Context, ds *backend.DataSourceInstance | |||
| if settings.IsServerless { | |||
| httpClientOptions.SigV4.Service = "aoss" | |||
| } | |||
| httpClientOptions.Middlewares = append(httpClientOptions.Middlewares, sigV4Middleware()) | |||
| authSettings, _ := awsds.ReadAuthSettingsFromContext(ctx) | |||
There was a problem hiding this comment.
I think you have to use the deprecated ReadAuthSettings or it doesn't work on older versions of grafana
There was a problem hiding this comment.
Hm... we should probably un-deprecate that, in that case. Given how it works under the hood, maybe we should just remove the deprecation and make ReadAuthSettingsFromContext private?
idastambuk
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #453, which needed the aws bump, which then entailed the sigv4 auth change.
Closes #453