Make Traces size settable #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
kevinwcyu and
njvrzm
and removed request for
a team
kevinwcyu
approved these changes
Jan 28, 2025
idastambuk
reviewed
Jan 29, 2025
| @@ -618,7 +618,7 @@ func (b *aggBuilderImpl) Stats() AggBuilder { | |||
| } | |||
|
|
|||
| // TraceList sets the "aggs" object of the query to OpenSearch for the trace list | |||
| func (b *aggBuilderImpl) TraceList() AggBuilder { | |||
| func (b *aggBuilderImpl) TraceList(spanLimit int) AggBuilder { | |||
There was a problem hiding this comment.
Then this is technically not just the "span" limit, right? Maybe we could make it more clear in the form too, that we're also setting the trace limit and not just span limit, by renaming the input to Size, or something similar? It's a common parameter in OpenSearch queries so I think the users would understand what it means too
idastambuk
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a field to the Lucene Traces query editor for setting the span limits.
Which issue(s) this PR fixes:
Fixes #484
Special notes for your reviewer: