wip

grafana · Dec 20, 2024 · 9fac9c9 · 9fac9c9
1 parent 4548611
commit 9fac9c9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -179,7 +179,7 @@ jobs:
         working-directory: ./${{ matrix.workingDir }}
 
       - name: Publish report to GCS (${{ steps.min-version.outputs.MIN_VERSION }})
-        if: ${{ github.repository_owner == 'grafana' && (failure() && steps.run-e2e-tests-oldest.outcome == 'failure') }}
+        if: ${{ github.repository_owner == 'grafana' && always()}}
         uses: grafana/plugin-actions/publish-report@main
         with:
           grafana-version: ${{ matrix.workingDir }}-${{ steps.min-version.outputs.MIN_VERSION }}

diff --git a/packages/create-plugin/templates/common/playwright.config b/packages/create-plugin/templates/common/playwright.config
@@ -31,7 +31,7 @@ export default defineConfig<PluginOptions>({
     baseURL: process.env.GRAFANA_URL || 'http://localhost:3000',
 
     /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
-    trace: 'on-first-retry',
+    trace: 'on',
   },
 
   /* Configure projects for major browsers */

diff --git a/packages/create-plugin/templates/datasource/tests/queryEditor.spec.ts b/packages/create-plugin/templates/datasource/tests/queryEditor.spec.ts
@@ -7,7 +7,8 @@ test('smoke: should render query editor', async ({ panelEditPage, readProvisione
   await expect(panelEditPage.getQueryEditorRow('A').getByRole('textbox', { name: 'Query Text' })).toBeVisible();
 });
 
-test('data query should return a value', async ({ panelEditPage, readProvisionedDataSource }) => {
+test('data query should return a value', async ({ panelEditPage, readProvisionedDataSource, grafanaVersion}) => {
+  console.log('grafanaVersion', grafanaVersion);
   const ds = await readProvisionedDataSource({ fileName: 'datasources.yml' });
   await panelEditPage.datasource.set(ds.name);
   await panelEditPage.setVisualization('Table');