Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Plugin E2E - allow overriding waitUntil in gotoPage fixtures #1110

Closed
2 of 7 tasks
sunker opened this issue Sep 11, 2024 · 1 comment · Fixed by #1111
Closed
2 of 7 tasks

Feat: Plugin E2E - allow overriding waitUntil in gotoPage fixtures #1110

sunker opened this issue Sep 11, 2024 · 1 comment · Fixed by #1111
Assignees
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@sunker
Copy link
Contributor

sunker commented Sep 11, 2024

Which areas does this feature request relate to

  • Create Plugin
  • Sign Plugin
  • Plugin E2E
  • Plugin Meta Extractor
  • Documentation

Problem

When navigating to Playwright pages using the goto method, one can pass an option called waitUntil which decides when the operation is considered succeeded. Across all pages models in plugin-e2e, networkidle mode is used by default. In practice this means navigation will resolve only when all network requests have been completed. Every plugin-e2e page model has a goto method that allows you to override this behaviour which is good.

A while back we introduced a new set of fixtures that allows you to quickly navigate to an existing resource (e.g await gotoDashboardPage({uid: 'abc' }). However, these goto<pagename> fixtures currently doesn't allow users to override waitUntil.

Solution

The goto<pagename> fixtures should allow user to override waitUntil.

Alternatives

No response

Additional context

No response

Are you interested in contributing the solution?

  • Yes
  • No
@sunker sunker added the enhancement New feature or request label Sep 11, 2024
@sunker sunker self-assigned this Sep 11, 2024
@sunker sunker moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community Sep 11, 2024
@github-project-automation github-project-automation bot moved this from 🧑‍💻 In development to 🚀 Shipped in Plugins Platform / Grafana Community Sep 11, 2024
@grafana-plugins-platform-bot
Copy link

🚀 Issue was released in @grafana/plugin-e2e@1.8.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant