Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Make it easier to navigate to existing resources #812

Merged
merged 12 commits into from
Mar 13, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Mar 13, 2024

What this PR does / why we need it:

This PR added a gotoAppConfigPage fixture which enabled quick navigation to an already existing app config page. This adds a new pattern on how to navigate to already existing resource:

test('test', async ({ gotoPanelEditPage }) => {
  const panelEditPage = await gotoPanelEditPage(dashboard);
})

The pattern before this was:

const page = new const panelEditPage = new PanelEditPage(
    { request, page, selectors, grafanaVersion, testInfo },
    {
      id: '5',
      dashboard: { uid: 'xyz' },
    }
  );
await panelEditPage.goto();

This PR adds corresponding fixtures for DashboardPage, PanelEditPage, AnnotationEditPage, VariableEditPage and DataSourceConfigPage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@0.21.0-canary.812.28681a8.0
# or 
yarn add @grafana/plugin-e2e@0.21.0-canary.812.28681a8.0

Copy link

github-actions bot commented Mar 13, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker added minor Increment the minor version when merged release Create a release when this pr is merged labels Mar 13, 2024
@mckn mckn self-requested a review March 13, 2024 09:43
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunker sunker marked this pull request as ready for review March 13, 2024 09:44
@sunker sunker requested a review from a team as a code owner March 13, 2024 09:44
@sunker sunker requested review from oshirohugo and removed request for a team March 13, 2024 09:44
@sunker sunker merged commit 9d661e8 into main Mar 13, 2024
21 checks passed
@sunker sunker deleted the plugin-e2e/goto-fixtures branch March 13, 2024 09:58
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.21.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants