Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-plugin migrate appears to be using plugin.name instead of id for docker-compose.yml #62

Closed
briangann opened this issue Sep 30, 2022 · 0 comments · Fixed by #109
Closed

create-plugin migrate appears to be using plugin.name instead of id for docker-compose.yml #62

briangann opened this issue Sep 30, 2022 · 0 comments · Fixed by #109
Assignees
@academo
Milestone
v1.0.0

Comments

@briangann
Copy link
Contributor

When running the migration, I ended up with a new docker-compose.yml file, and it used the plugin "name" instead of the "id" in a couple of locations.

It also detects that I had a docker-compose.yaml file and wanted to delete it.

Maybe detect if the repo is using .yaml and skip the migration for it? or rename/merge in changes?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@academo academo

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Use normalize_id for docker-compose.yml instead of only pluginName grafana/plugin-tools
3 participants
@jackw @academo @briangann