Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use normalize_id for docker-compose.yml instead of only pluginName #109

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Use normalize_id for docker-compose.yml instead of only pluginName #109

merged 2 commits into from
Oct 24, 2022

Conversation

academo
Copy link
Member

@academo academo commented Oct 24, 2022 •
edited
Loading

Fixes: #62

Using the pluginId instead of only the pluginName

Example of a newly generated docker-compose file:

version: '3.0'

services:
  grafana:
    container_name: 'myorg-myplugin-panel'
    build:
      context: ./.config
      args:
        grafana_version: ${GRAFANA_VERSION:-9.1.2}
    ports:
      - 3000:3000/tcp
    volumes:
      - ./dist:/var/lib/grafana/plugins/myorg-myplugin-panel
      - ./provisioning:/etc/grafana/provisioning

@academo academo changed the title Use normalize_id for docker-compose instead of only pluginName Use normalize_id for docker-compose.yml instead of only pluginName Oct 24, 2022
@academo academo requested review from briangann and jackw and removed request for briangann October 24, 2022 11:08
@academo academo self-assigned this Oct 24, 2022
@academo academo added the enhancement New feature or request label Oct 24, 2022
@academo academo added this to the v1.0.0 milestone Oct 24, 2022
jackw
jackw approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! 🚀

@academo academo merged commit 826e7eb into main Oct 24, 2022
@academo academo deleted the academo/fix-docker-compose-generation branch October 24, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@briangann briangann Awaiting requested review from briangann

@leventebalogh leventebalogh Awaiting requested review from leventebalogh

Assignees

@academo academo

Labels
enhancement New feature or request
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

create-plugin migrate appears to be using plugin.name instead of id for docker-compose.yml
2 participants
@academo @jackw