Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Fix CI workflow for E2E tests to successfully run #1001

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Jul 11, 2024

What this PR does / why we need it:

This PR fixes the following issues with a newly scaffolded plugin failing to run e2e tests:

  1. The CI workflow currently has a hardcoded backend file name when trying to chmod the files. This PR addresses this by using a wildcard to chmod all files in ./dist that start gpx_.
  2. The CI workflow currently only downloads the built plugin artefacts if there is a backend component. This PR addresses this by removing the if logic in the step.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.16.2-canary.1001.ebc5fe7.0
# or 
yarn add @grafana/create-plugin@4.16.2-canary.1001.ebc5fe7.0

@jackw jackw added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 11, 2024
@jackw jackw self-assigned this Jul 11, 2024
@jackw jackw requested a review from a team as a code owner July 11, 2024 15:04
@jackw jackw requested review from leventebalogh and removed request for a team July 11, 2024 15:04
Copy link

github-actions bot commented Jul 11, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw changed the title Create Plugin: Fix chmod command in CI workflow Create Plugin: Fix CI workflow for E2E tests to successfully run Jul 11, 2024
@jackw jackw merged commit fb3a0b4 into main Jul 12, 2024
15 checks passed
@jackw jackw deleted the jackw/fix-chmod-ci branch July 12, 2024 07:00
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.16.2 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants