Create-Plugin: Simplify Prompts #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
create-plugin
…emove description
…o mod version etc
jackw
requested review from
oshirohugo,
academo,
leventebalogh and
sympatheticmoose
and removed request for
a team
leventebalogh
approved these changes
Jul 22, 2024
packages/create-plugin/src/commands/generate/update-go-sdk-and-packages.ts
Show resolved
Hide resolved
…ean up duplicate console.log
| @@ -53,22 +53,22 @@ jobs: | |||
| matrix: | |||
| include: | |||
| - workingDir: 'myorg-nobackend-app' | |||
| cmd: create-plugin --pluginName='no-backend' --orgName='myorg' --pluginDescription='This is a sample app.' --pluginType='app' --no-hasBackend --hasGithubWorkflows --hasGithubLevitateWorkflow | |||
| cmd: create-plugin --pluginName='no-backend' --orgName='myorg' --pluginType='app' --no-hasBackend | |||
There was a problem hiding this comment.
incredibly nitty comment which you are welcome to resolve as "go away David" - but maybe cleaner if the args are in the same order as the prompts
| hasBackend: true | ||
| - workingDir: 'myorg-nobackendscenes-app' | ||
| cmd: create-plugin --pluginName='no-backend-scenes' --orgName='myorg' --pluginDescription='This is a sample scenes app.' --pluginType='scenesapp' --no-hasBackend --hasGithubWorkflows --hasGithubLevitateWorkflow | ||
| cmd: create-plugin --pluginName='no-backend-scenes' --orgName='myorg' --pluginType='scenesapp' --no-hasBackend |
There was a problem hiding this comment.
missing scenes with backend?
| "generate-datasource": "tsc && npm run clean-generated && CREATE_PLUGIN_DEV=true node ./dist/bin/run.js --pluginName='Sample datasource' --orgName='sample-org' --pluginDescription='This is a sample datasource.' --pluginType='datasource' --no-hasBackend --hasGithubWorkflows --hasGithubLevitateWorkflow", | ||
| "generate-datasource-backend": "tsc && npm run clean-generated && CREATE_PLUGIN_DEV=true node ./dist/bin/run.js --pluginName='Sample datasource' --orgName='sample-org' --pluginDescription='This is a sample datasource.' --pluginType='datasource' --hasBackend --hasGithubWorkflows --hasGithubLevitateWorkflow", | ||
| "generate-app": "tsc && npm run clean-generated && CREATE_PLUGIN_DEV=true node ./dist/bin/run.js --pluginName='Sample app' --orgName='sample-org' --pluginType='app' --no-hasBackend", | ||
| "generate-scenes-app": "tsc && npm run clean-generated && CREATE_PLUGIN_DEV=true node ./dist/bin/run.js --pluginName='Sample scenesapp' --orgName='sample-org' --pluginType='scenesapp' --no-hasBackend", |
There was a problem hiding this comment.
missing scenes backend option?
….github directory
Co-authored-by: David Harris <david.harris@grafana.com>
|
The new flow is much more streamlined, looking forward to this being merged. Nice work! |
Co-authored-by: David Harris <david.harris@grafana.com>
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the following changes:
Whilst we don't believe anyone is using the cliArgs (other than ourselves) to set prompt answers I've nonetheless set this as a major breaking change due to the removal of the workflow related cliArgs.
Which issue(s) this PR fixes:
Fixes #995
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.0.0-canary.1018.f1b5b46.0 # or yarn add @grafana/create-plugin@5.0.0-canary.1018.f1b5b46.0