Create Plugin: Template dynamic public path #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it supports pluginId changes
jackw
added
create-plugin
jackw
requested review from
oshirohugo,
academo and
leventebalogh
and removed request for
a team
academo
approved these changes
Jul 25, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It's become apparent that making the
publicPath.tsa static file can result in developer issues due to either editing of the file or changing their plugin id which would require them to rerun the create-plugin update command so the correct fallback urlpublic/plugins/{{pluginId}}is regenerated.This PR offers a solution to this by making the publicPath.ts file an in-memory module that uses template literals to inject the plugin id at build time from the plugin.json file.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.16.3-canary.1023.697917b.0 # or yarn add @grafana/create-plugin@4.16.3-canary.1023.697917b.0