Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-Plugin: Add smoke tests to scenes app template #1039

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Aug 7, 2024

What this PR does / why we need it:

This PR adds basic smoke tests to the scenes app template. The tests are copied from the examples repo and were recently added by Yulia. Adding these smoke tests should allow us to upgrade the scenes package with more confidence (e2e tests for the scaffolded plugin are executed as part of ci).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sunker sunker requested a review from a team as a code owner August 7, 2024 08:44
@sunker sunker requested review from jackw and removed request for a team August 7, 2024 08:44
Copy link

github-actions bot commented Aug 7, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Aug 7, 2024
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the new tests!

@sunker sunker merged commit f500518 into main Aug 7, 2024
18 of 19 checks passed
@sunker sunker deleted the create-plugin/scenes-template-e2e-tests branch August 7, 2024 08:52
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.2.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants