Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: Wrap app config fields with <form> #1041

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Create Plugin: Wrap app config fields with <form> #1041

merged 3 commits into from
Aug 27, 2024

Conversation

leventebalogh
Copy link
Collaborator

@leventebalogh leventebalogh commented Aug 7, 2024 •
edited by grafana-plugins-platform-bot bot
Loading

What changed?

  • app templates: wrapped the config fields with a <form> element
  • scenes app templates:
    • wrapped the config fields with a <form> element
    • removed the obsolete enable/disable logic (already part of the header)
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.3.3-canary.1041.1ab47f9.0
# or 
yarn add @grafana/create-plugin@5.3.3-canary.1041.1ab47f9.0

@leventebalogh leventebalogh added enhancement New feature or request create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Aug 7, 2024
@leventebalogh leventebalogh self-assigned this Aug 7, 2024
@leventebalogh leventebalogh requested a review from a team as a code owner August 7, 2024 18:46
@leventebalogh leventebalogh requested review from jackw and removed request for a team August 7, 2024 18:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

jackw
jackw approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Left a couple of nits.

packages/create-plugin/templates/app/src/components/AppConfig/AppConfig.tsx Show resolved Hide resolved
packages/create-plugin/templates/scenes-app/src/components/AppConfig/AppConfig.tsx Outdated Show resolved Hide resolved
sunker
sunker approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/create-plugin/templates/app/src/components/AppConfig/AppConfig.tsx Show resolved Hide resolved
@leventebalogh leventebalogh force-pushed the leventebalogh/update-app-configs branch from 1247c8a to f587936 Compare August 27, 2024 16:34
@leventebalogh leventebalogh merged commit 60bb309 into main Aug 27, 2024
13 checks passed
@leventebalogh leventebalogh deleted the leventebalogh/update-app-configs branch August 27, 2024 16:57
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.3.3 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@sunker sunker sunker approved these changes

Assignees

@leventebalogh leventebalogh

Labels
create-plugin related to the create-plugin tool enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leventebalogh @jackw @sunker