Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Fix typings for the toHaveAlert matcher #1070

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Aug 21, 2024

What this PR does / why we need it:

Fix typings for the toHaveAlert expect matcher.

Which issue(s) this PR fixes:

Fixes ##1010

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.3.0-canary.1070.82881c3.0
npm install @grafana/plugin-e2e@1.7.0-canary.1070.82881c3.0
# or 
yarn add @grafana/create-plugin@5.3.0-canary.1070.82881c3.0
yarn add @grafana/plugin-e2e@1.7.0-canary.1070.82881c3.0

@sunker sunker requested a review from academo August 21, 2024 08:49
@sunker sunker requested a review from a team as a code owner August 21, 2024 08:49
@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sunker sunker merged commit e1f6ddd into main Aug 21, 2024
20 checks passed
@sunker sunker deleted the plugin-e2e/fix-to-have-alert-typings branch August 21, 2024 11:43
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@1.7.1 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Aug 21, 2024
@sunker sunker restored the plugin-e2e/fix-to-have-alert-typings branch August 21, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants