Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: Bump typescript to v5 for plugins #1073

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Create Plugin: Bump typescript to v5 for plugins #1073

merged 1 commit into from
Aug 28, 2024

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Aug 26, 2024 •
edited by grafana-plugins-platform-bot bot
Loading

What this PR does / why we need it:
Bumps TS to v5 for plugins.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.3.3-canary.1073.96d0672.0
# or 
yarn add @grafana/create-plugin@5.3.3-canary.1073.96d0672.0

@jackw jackw added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Aug 26, 2024
@jackw jackw self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw marked this pull request as ready for review August 26, 2024 13:22
@jackw jackw requested a review from a team as a code owner August 26, 2024 13:22
@jackw jackw requested review from oshirohugo and removed request for a team August 26, 2024 13:22
sunker
sunker approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and appears to work fine 👍

leventebalogh
leventebalogh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think it makes sense to always have it on the same version as what the latest Grafana has. 👍

@jackw jackw merged commit 4ec945c into main Aug 28, 2024
16 checks passed
@jackw jackw deleted the jackw/bump-plugins-ts5 branch August 28, 2024 06:32
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.3.4 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunker sunker sunker approved these changes

@leventebalogh leventebalogh leventebalogh approved these changes

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees

@jackw jackw

Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackw @sunker @leventebalogh