Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating app template to use compatible icon #110

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

tolzhabayev
Copy link
Collaborator

What this PR does / why we need it:
The current template will not build against canary release as it will fail with. This PR updates the icon to make it compatible.

TS2322: Type '"fa fa-cog"' is not assignable to type '"search" | "repeat" | "anchor" | "link" | "table" | "circle" | "filter" | "info" | "google" | "microsoft" | "github" | "gitlab" | "okta" | "angle-double-down" | "angle-double-right" | ... 172 more ... | undefined'.
     5 | export const plugin = new AppPlugin<{}>().setRootPage(App).addConfigPage({
     6 |   title: 'Configuration',
  >  7 |   icon: 'fa fa-cog',
       |   ^^^^
     8 |   // @ts-ignore - Would expect a Class component, however works absolutely fine with a functional one
     9 |   // Implementation: https://github.com/grafana/grafana/blob/fd44c01675e5497[33](https://github.com/grafana/grafana-plugin-examples/actions/runs/3298636396/jobs/5441011599#step:24:34)70969dfb9e78f173aff7910/public/app/features/plugins/PluginPage.tsx#L157
    10 |   body: AppConfig,

webpack 5.74.0 compiled with 1 error in 6000 ms

@tolzhabayev tolzhabayev requested a review from a team October 24, 2022 14:02
@tolzhabayev tolzhabayev self-assigned this Oct 24, 2022
@tolzhabayev tolzhabayev requested review from mckn and removed request for a team October 24, 2022 14:02
@tolzhabayev tolzhabayev added the create-plugin related to the create-plugin tool label Oct 24, 2022
@tolzhabayev tolzhabayev merged commit e9792f6 into main Oct 24, 2022
@tolzhabayev tolzhabayev deleted the chore/update-app-template-to-use-cog branch October 24, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool
Projects
Development

Successfully merging this pull request may close these issues.

2 participants