Switch to createDataFrame #1133
Conversation
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged but will not trigger a new release. To trigger a new release add the |
tolzhabayev
added
patch
| @@ -77,7 +76,7 @@ export class DataSource extends DataSourceApi<MyQuery, MyDataSourceOptions> { | |||
| } | |||
| } catch (err) { | |||
| let message = ''; | |||
| if (_.isString(err)) { | |||
| if (typeof err === 'string') { | |||
There was a problem hiding this comment.
I couldn't find any other places we are using lodash on scaffolding so I removed it - the developers can add it back when needed and it is removed by webpack on bundle anyway.
There was a problem hiding this comment.
@jackw anything against that ☝️
There was a problem hiding this comment.
👍
This method is a bit of a mess, so would be nice to improve at some point. Maybe grafana/data could expose a function that returns message from an unknown error.
tolzhabayev
requested review from
oshirohugo
and removed request for
a team
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
What this PR does / why we need it:
Move from deprecated
MutableDataFrameto the function the createsDataFrame'sWhich issue(s) this PR fixes:
Fixes #763
Special notes for your reviewer: