Plugin E2e: Support scenes powered dashboard UI #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
patch
sunker
force-pushed
the
plugin-e2e/fix-apply-bug
branch
from
a60332e
to
9ee9199
Compare
sunker
force-pushed
the
plugin-e2e/fix-apply-bug
branch
from
185a20e
to
e5daed5
Compare
sunker
requested review from
oshirohugo and
mckn
and removed request for
a team
4 tasks
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Scenes powered dashboards was enabled by default in Grafana recently. This included some changes that broke plugin e2e APIs in some certain scenarios:
Applybutton is renamed toBack to dashboardand there was a new e2e selector for theBack to dashboardbuttonEditbuttonUnfortunately, these changes were not captured by the API tests in Grafana (apply method was never tested and addPanel was only tested for new dashboards - not already existing ones).
Which issue(s) this PR fixes:
Fixes #1152
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.4.1-canary.1155.64c8314.0 npm install @grafana/plugin-e2e@1.8.3-canary.1155.64c8314.0 # or yarn add @grafana/create-plugin@5.4.1-canary.1155.64c8314.0 yarn add @grafana/plugin-e2e@1.8.3-canary.1155.64c8314.0