CI: Introduce commands workflow to run on Linux, Mac and Windows #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
approved these changes
Nov 28, 2022
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
Should we extend it with macos-latest at least? (I am not sure windows-latest would work out of the box as well, but maybe it should?)
| # env: | ||
| # GRAFANA_API_KEY: ${{ secrets.GRAFANA_API_KEY }} | ||
| # run: node ../../sign-plugin/dist/bin/run.js --rootUrls http://www.example.com --signatureType private | ||
| # working-directory: ./packages/create-plugin/generated |
There was a problem hiding this comment.
Should we get rid of this commented out code?
|
I'm closing this for now. Until we find a way around bypassing conditional prompts I can't see a way forward for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces a new "commands" workflow to validate the commands in the bundled packages work on all flavours of OS. This should help us catch issues with cross operating system compatibility without the need for firing up virtual machines locally.
It also bumps the versions of the actions used as per #114