Manually rename gitignore to prevent yarn and npm pack from removing them #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It makes sure that generated plugins contain a
.gitignorefile.Npm and yarn will not include
.gitignorefiles when packing packages and this means the release version of create-plugin will not generate this file. The suggested fixes of creating a.npmignoreand.yarnignorefiles to prevent this behaviour don't work.This PR implements a simple exception to include the gitignore file without the dot prefix and rename it when the plugin is generated.
More details of this behaviour npm/npm#3763 (comment)
Which issue(s) this PR fixes:
Fixes # #116
Special notes for your reviewer:
If you want to test this PR you should first run
yarn buildand thenyarn packand inspect the packed file to reproduce the error (note the lack of.gitignorein the package).