Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plugin: Fix plugin.json check step on CI #1330

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Nov 15, 2024

What this PR does / why we need it:

This fix the plugin.json check step that was introduced to the CI created by create-plugin

Which issue(s) this PR fixes:

Fixes #1328

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.9.3-canary.1330.d739d35.0
# or 
yarn add @grafana/create-plugin@5.9.3-canary.1330.d739d35.0

@oshirohugo oshirohugo added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 15, 2024
@oshirohugo oshirohugo self-assigned this Nov 15, 2024
@oshirohugo oshirohugo requested a review from a team as a code owner November 15, 2024 08:26
@oshirohugo oshirohugo requested review from leventebalogh and removed request for a team November 15, 2024 08:26
Copy link

github-actions bot commented Nov 15, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@oshirohugo oshirohugo merged commit d5a5e79 into main Nov 15, 2024
14 checks passed
@oshirohugo oshirohugo deleted the fix-check-plugin-json-ci-step branch November 15, 2024 09:04
@oshirohugo
Copy link
Contributor Author

A second PR will be open to check the plugin.json from the tests scaffolded plugins CI

@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.9.3 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Nov 15, 2024
@oshirohugo oshirohugo mentioned this pull request Nov 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

Bug: Check plugin.json fails
2 participants