-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugin: Support Yarn Berry #1438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jackw
added
minor
Increment the minor version when merged
release
Create a release when this pr is merged
create-plugin
related to the create-plugin tool
labels
Jan 8, 2025
jackw
changed the title
Create Plugin: Use Yarn Berry
Create Plugin: Use Yarn Berry for new scaffolds
Jan 9, 2025
jackw
changed the title
Create Plugin: Use Yarn Berry for new scaffolds
Create Plugin: Support Yarn Berry
Jan 10, 2025
jackw
force-pushed
the
jackw/use-yarn-berry
branch
from
January 10, 2025 15:05
bf81699
to
c93f38d
Compare
sunker
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🚀
leventebalogh
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
This issue/pull request has been released.
label
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
create-plugin
related to the create-plugin tool
minor
Increment the minor version when merged
release
Create a release when this pr is merged
released
This issue/pull request has been released.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes create-plugin so plugin scaffolds that are run with yarn berry (>=2.0.0) will have the yarn config set to
nodeLinker: node-modules
for compatibility with tooling / ci scripts. It also updates the yarn install commands and changes the docs so the yarn commands are berry compatible and adds a note suggesting plugin devs upgrade their version of yarn.Test scaffold and CI checks repo.
Test PR for gh workflows.
Test release gh workflows
This does not affect
create-plugin update
command.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.13.0-canary.1438.c93f38d.0 # or yarn add @grafana/create-plugin@5.13.0-canary.1438.c93f38d.0