Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Support Yarn Berry #1438

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Create Plugin: Support Yarn Berry #1438

merged 7 commits into from
Jan 13, 2025

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Jan 8, 2025

What this PR does / why we need it:

This PR changes create-plugin so plugin scaffolds that are run with yarn berry (>=2.0.0) will have the yarn config set to nodeLinker: node-modules for compatibility with tooling / ci scripts. It also updates the yarn install commands and changes the docs so the yarn commands are berry compatible and adds a note suggesting plugin devs upgrade their version of yarn.

Test scaffold and CI checks repo.
Test PR for gh workflows.
Test release gh workflows

This does not affect create-plugin update command.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.13.0-canary.1438.c93f38d.0
# or 
yarn add @grafana/create-plugin@5.13.0-canary.1438.c93f38d.0

@jackw jackw requested a review from a team as a code owner January 8, 2025 15:42
@jackw jackw requested a review from Ukochka January 8, 2025 15:42
@jackw jackw changed the title Jackw/use yarn berry Create Plugin: Use Yarn Berry Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw self-assigned this Jan 8, 2025
@jackw jackw marked this pull request as draft January 8, 2025 15:43
@jackw jackw added minor Increment the minor version when merged release Create a release when this pr is merged create-plugin related to the create-plugin tool labels Jan 8, 2025
@jackw jackw marked this pull request as ready for review January 9, 2025 09:40
@jackw jackw changed the title Create Plugin: Use Yarn Berry Create Plugin: Use Yarn Berry for new scaffolds Jan 9, 2025
@jackw jackw changed the title Create Plugin: Use Yarn Berry for new scaffolds Create Plugin: Support Yarn Berry Jan 10, 2025
@jackw jackw force-pushed the jackw/use-yarn-berry branch from bf81699 to c93f38d Compare January 10, 2025 15:05
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🚀

Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jackw jackw merged commit 1266043 into main Jan 13, 2025
13 checks passed
@jackw jackw deleted the jackw/use-yarn-berry branch January 13, 2025 10:02
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.13.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants