Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: make it possible to delete folders with content #18

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

leventebalogh
Copy link
Collaborator

What changed?

Until now the migrate command was failing when it was trying to delete folders that became unnecessary in the plugin (e.g. ./webpack) in case they were containing files. This pull request is fixing that by using the -r and -f flags in the utility function.

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tolzhabayev tolzhabayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force!

@leventebalogh leventebalogh merged commit 43a0dd0 into main Jun 1, 2022
@leventebalogh leventebalogh deleted the leventebalogh/fix-folder-deletion branch June 1, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants