Feature: adding datasource backend template #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
approved these changes
Jan 24, 2022
Comment on lines
+7
to
+8
| "backend": true, | ||
| "executable": "gpx_{{ snakeCase pluginName }}", |
There was a problem hiding this comment.
Should we wrap these backend specific properties with hasBackend for datasource plugins that don't have a backend? 🤔 e.g.
{{#if hasBackend}}
"backend": true,
"executable": "gpx_{{ snakeCase pluginName }}",
{{/if}}
There was a problem hiding this comment.
Yes! We should probably remove the possibility to scaffold a datsource plugin without a backend so maybe we should restructure this a bit.
Oh, I didn't know that you could to as you are show casing above.
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following: