Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datasource without backend template and update test CI #206

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

academo
Copy link
Member

@academo academo commented Mar 2, 2023

  • Update scripts to generate a datasource plugin with and without backend
  • Remove unused import from datasource template
  • Update ci to include app with backend and datasource without backend
  • Use grafana 9.3.8 in dependencies

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@academo academo self-assigned this Mar 2, 2023
@academo academo added create-plugin related to the create-plugin tool type/bug Something isn't working labels Mar 2, 2023
@academo academo requested a review from jackw March 2, 2023 13:40
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

const path = require('path');
const fs = require('fs');

async function generatePanel() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: probably generateDatasource() instead, although generate() would be probably better as it's "copy-paste safer" :)

@academo academo merged commit 2b9b5c9 into main Mar 6, 2023
@academo academo deleted the academo/create-plugin-updates branch March 6, 2023 09:26
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@1.1.0 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool released This issue/pull request has been released. type/bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants