Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to run tests on push #22

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Add job to run tests on push #22

merged 3 commits into from
Jul 21, 2022

Conversation

academo
Copy link
Member

@academo academo commented Jul 18, 2022

Closes #21

  • Adds a github workflow to test and publish to npm.
  • Adds the engine section in package.json to check the nodejs version. Set to nodejs 16 LTS
  • Keeps the existing tsc build.
  • Fixes eslint trying to lint templates.

@academo academo self-assigned this Jul 18, 2022
@academo academo added the enhancement New feature or request label Jul 18, 2022
@academo academo marked this pull request as ready for review July 18, 2022 10:52
@academo academo requested a review from jackw July 19, 2022 11:42
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

package.json Outdated Show resolved Hide resolved
if: steps.version_check.outputs.changed == 'true'
run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add this secret before we can actually release the package! 🚀

@academo academo merged commit e74598b into main Jul 21, 2022
@academo academo deleted the academo/release-workflow branch July 21, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Bundle and publish to NPM
2 participants