Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreatePlugin: Add vscode launch.json files for backend debug mode #224

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Mar 15, 2023

What this PR does / why we need it:

Adds .vscode/launch.json for backend debug run configuration and bumps grafana-plugin-sdk-go to the latest version (which supports the new backend debug mode)

Which issue(s) this PR fixes:

Special notes for your reviewer:

@xnyo xnyo added enhancement New feature or request create-plugin related to the create-plugin tool labels Mar 15, 2023
@xnyo xnyo self-assigned this Mar 15, 2023
@xnyo xnyo marked this pull request as draft March 15, 2023 11:55
@xnyo xnyo changed the title WIP: CreatePlugin: Add vscode launch.json files for backend debug mode CreatePlugin: Add vscode launch.json files for backend debug mode Mar 15, 2023
@xnyo xnyo marked this pull request as ready for review March 16, 2023 16:54
@xnyo xnyo requested review from jackw, academo and mckn March 16, 2023 16:54
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xnyo xnyo merged commit 65ea603 into main Mar 20, 2023
@xnyo xnyo deleted the giuseppe/backend-debug branch March 20, 2023 10:40
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@1.2.1 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool enhancement New feature or request released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants