Website: Introduce Snippets for FE Package Managers #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
previously approved these changes
Apr 27, 2023
| async function fetchSnippets() { | ||
| const fetchedSnippets = await Promise.all( | ||
| snippetPaths.map(async (path) => { | ||
| const [_, value, language] = path.split('.'); |
There was a problem hiding this comment.
I would probably add a block of comments above the component definition that explains how to use this component on the call-site, especially how the name of the file relates to the names of the tabs.
…allow single snippet
…emanager for syncing commands
jackw
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to load markdown snippets inside syntax highlighted code blocks. Right now it can be used to tab between different package managers.
It can also be used in combination with the
SyncCommandcomponent to update inline code blocks:Kapture.2023-05-02.at.17.53.05.mp4
Which issue(s) this PR fixes:
Related issue: #156
Special notes for your reviewer: