Test generated plugins on the pipeline #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2022 13:24
academo
changed the title
academo
commented
Jul 21, 2022
| @@ -10,6 +10,11 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| ref: ${{ github.ref }} | |||
| - name: Setup .npmrc file for NPM registry | |||
There was a problem hiding this comment.
missed this bit in the previous PR.
There was a problem hiding this comment.
I'm curious why we need to do this here for test, lint etc. Later when publishing it looks like we do this here. 🤔
There was a problem hiding this comment.
It is not really necessary for the ubuntu-latest image in github but then we are running the nodejs version that github provides on their runners. This guarantees we run the nodejs version we specify. Also when I was testing with act (local github workflows runner) if I didn't use this it would not run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Closes #13