Chore: Remove axios as a dependency for sign-plugin #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
chore
jackw
added
patch
mckn
approved these changes
Jul 10, 2023
| status: number; | ||
| } | ||
|
|
||
| export async function postData(urlString: string, data: unknown, headers: Headers): Promise<Response<string>> { |
There was a problem hiding this comment.
Suggested change
| export async function postData(urlString: string, data: unknown, headers: Headers): Promise<Response<string>> { | |
| export function postData(urlString: string, data: unknown, headers: Headers): Promise<Response<string>> { |
There was a problem hiding this comment.
Good point! Usually the linter catches these things. I'll see if I can modify the rules so this is automatically suggested.
tolzhabayev
approved these changes
Jul 10, 2023
|
🚀 PR was released in |
grafana-delivery-bot
bot
added
the
released
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes axios as a dependency for sign-plugin. Axios is only used to make a single post request and it adds a layer of "black box" that can make situations like #290 harder to diagnostic.
Test run with a success case
Test run with an error case
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/sign-plugin@1.0.3-canary.292.c5013c7.0 # or yarn add @grafana/sign-plugin@1.0.3-canary.292.c5013c7.0