Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves create command user experience #39

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Improves create command user experience #39

merged 3 commits into from
Sep 9, 2022

Conversation

academo
Copy link
Member

@academo academo commented Sep 2, 2022

Closes #38

  • It validates the name and organization ID are entered
  • It creates a new folder based on the name and organization id instead of creating the plugin in the current folder.

@academo academo requested a review from jackw September 5, 2022 11:58
@academo academo self-assigned this Sep 5, 2022
@academo academo added the enhancement New feature or request label Sep 5, 2022
jackw
jackw approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

src/commands/generate.plopfile.ts Outdated
hasGithubLevitateWorkflow,
}: CliArgs) {
const exportPath = getExportPath(pluginName, orgName, pluginType);
console.log(exportPath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for debug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is.

@academo academo merged commit 3b93341 into main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

Assignees

@academo academo

Labels
enhancement New feature or request
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer experience improvements for the create command
2 participants
@academo @jackw