Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: building a single plugin as module directly in the dist folder #52

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

mckn
Copy link
Collaborator

@mckn mckn commented Sep 27, 2022

When I introduced #50 I broke the support for single plugin repositories by always put the plugin dist/${pluginName}/module.js. This PR will fix that issue by always putting a single plugin repo directly below dist/module.js.

We should probably add tests for the most simple scenarios. Will open another PR about that.

@mckn mckn marked this pull request as ready for review September 27, 2022 13:17
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@mckn mckn merged commit 7d91cbb into main Sep 28, 2022
@mckn mckn deleted the mckn/single-plugin-scenario-bug branch September 28, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants