Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin-E2E: Add version resolver action #584

Closed
wants to merge 11 commits into from

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Dec 13, 2023

What this PR does / why we need it:

This PR adds an Github Action action that has the purpose of resolving what Grafana versions to target in the E2E tests. The output of the action is a json array of Grafana minor versions that can be used to specify a version matrix in the next workflow job. See this example.

Currently, the actions support two modes:

plugin-grafana-dependency (default)
The will return all minor versions of Grafana since the version that was specified as grafanaDependency in the plugin.json. (does not work for this repo since it's not a plugin).

version-support-policy
This will resolve versions according to the min support policy defined in this doc. TLDR; all minors for the current major version and the last minor of the previous major version.

If a plugin author requires more flexibility, they can ofc define their own matrix.

At some point (when it's more stable) we probably want to move this action to its own repo and tag a release. Maybe also rewrite using Typescript.

Which issue(s) this PR fixes:

Fixes #
Part of #576

Special notes for your reviewer:
For now I'm just creating a bundle using the following command and committing it.

npx ncc build ./index.js -o output

When the action is moved to its own repo, we can look at better alternatives for this.

Copy link

github-actions bot commented Dec 13, 2023

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@sunker sunker added the no-changelog Don't include in changelog and version calculations label Dec 13, 2023
@sunker sunker mentioned this pull request Dec 13, 2023
6 tasks
@sunker sunker changed the title [WIP] Plugin-E2E: Add version resolver action Plugin-E2E: Add version resolver action Dec 13, 2023
@sunker sunker requested review from academo and jackw December 13, 2023 14:17
@sunker sunker marked this pull request as ready for review December 13, 2023 14:18
@sunker sunker requested a review from a team as a code owner December 13, 2023 14:18
paths:
- 'packages/plugin-e2e/**'
# paths:
# - 'packages/plugin-e2e/**'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to uncomment before merging

@jackw
Copy link
Collaborator

jackw commented Dec 13, 2023

At some point (when it's more stable) we probably want to move this action to its own repo and tag a release. Maybe also rewrite using Typescript.

I was going to suggest this could be moved to the plugin-actions repo.

@sunker
Copy link
Contributor Author

sunker commented Dec 13, 2023

At some point (when it's more stable) we probably want to move this action to its own repo and tag a release. Maybe also rewrite using Typescript.

I was going to suggest this could be moved to the plugin-actions repo.

Ah sweet, didn't know we had that repo. In that case I'm closing this PR. Will open a new one in plugin-actions shortly.

@sunker sunker closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Don't include in changelog and version calculations
Projects
Development

Successfully merging this pull request may close these issues.

2 participants