Plugin E2E: Replace magic strings with selectors #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
sunker
added
the
no-changelog
sunker
changed the title
sunker
requested review from
oshirohugo,
jackw,
academo and
a team
and removed request for
a team
sunker
force-pushed
the
plugin-e2e/refactor-selectors
branch
from
e6c1b9b
to
56f4609
Compare
academo
reviewed
Dec 15, 2023
| @@ -20,7 +20,7 @@ test('should load resources and display them as options when clicking on an inpu | |||
| await variableEditPage.datasource.set(provision.datasources?.[0]!.name!); | |||
| await page.getByLabel('Schema').click(); | |||
| await expect(variableEditPage.getByTestIdOrAriaLabel('Select option')).toContainText(REDSHIFT_SCHEMAS); | |||
| await page.keyboard.press('Escape'); | |||
| await page.keyboard.press('Enter'); | |||
There was a problem hiding this comment.
Yes - In Grafana 9.2.x (and earlier), hitting Escape takes you away from dashboard settings and back to the dashboard start page. So needed some other command that can move focus away from the select, but still stay on the same page.
academo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In this PR I'm replacing all remaining magic strings with proper selectors defined in
e2e-selectors.Which issue(s) this PR fixes:
Fixes #
Part of #576
Special notes for your reviewer: