Plugin E2E: Harmonise model instantiation and navigation #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
force-pushed
the
plugin-e2e/harmonize-model-instantiation
branch
from
3f7e67f
to
f1f8193
Compare
sunker
added
the
no-changelog
sunker
changed the title
sunker
added
minor
academo
approved these changes
Dec 19, 2023
grafana-plugins-platform-bot
bot
added
the
released
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Up until now, it has only been possible to instantiate and navigate to annotations, variables, panels etc for new dashboards (
/dashboard/new). This is probably all plugin authors need in most cases. However, I want it to be possible to also instantiate all pages with a dashboard uid so it's possible to navigate to an already existing dashboard. This is useful if you for example want to test template variable interpolation in your datasource file, and you want to use a template variable and a query that is using the variable in a provisioned dashboard.This PR harmonises the constructor method and the
gotomethod for all page models. I'm also adding a few tests that showcases how this pages can be instantiated and navigated to also for an existing dashboard.Which issue(s) this PR fixes:
Part of #576
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@0.1.0-canary.603.428a5d1.0 # or yarn add @grafana/plugin-e2e@0.1.0-canary.603.428a5d1.0