Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin E2E: Use module nodenext #608

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Plugin E2E: Use module nodenext #608

merged 1 commit into from
Dec 18, 2023

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Dec 15, 2023 •
edited
Loading

What this PR does / why we need it:
Playwright's test-runner does internally determine what kind of fixtures it has to create and load. When using a single variable name without destructing, this is not possible since it needs to load all fixtures. With nodenext enabled, destructuring assignment is not transpiled to single variables.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@0.0.2-canary.608.ac608e9.0
# or 
yarn add @grafana/plugin-e2e@0.0.2-canary.608.ac608e9.0

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Dec 15, 2023
@github-actions GitHub Actions
Copy link

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker changed the title Plugin E2E: Use module nodenext [WIP]Plugin E2E: Use module nodenext Dec 15, 2023
@sunker sunker marked this pull request as ready for review December 18, 2023 08:25
@sunker sunker requested a review from a team as a code owner December 18, 2023 08:25
@sunker sunker requested review from oshirohugo and removed request for a team December 18, 2023 08:25
@sunker sunker requested a review from jackw December 18, 2023 09:38
@sunker sunker changed the title [WIP]Plugin E2E: Use module nodenext Plugin E2E: Use module nodenext Dec 18, 2023
jackw
jackw approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sunker sunker merged commit 938dca5 into main Dec 18, 2023
21 checks passed
@sunker sunker deleted the plugin-e2e/ts-node-next branch December 18, 2023 15:38
@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Dec 18, 2023
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunker @jackw