Plugin E2E: Add expect matcher for alert box #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
patch
sunker
force-pushed
the
plugin-e2e/expect-alert
branch
from
7379ad2
to
b925ceb
Compare
academo
approved these changes
Dec 19, 2023
grafana-plugins-platform-bot
bot
added
the
released
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ideally in the data source config page, we'd want to assert that a config is valid by looking at the response for the call to the
healthendpoint in the plugin backend. However, not all data source plugins has a backend, and in the case they don't make use of a ds proxy either, we need another way of asserting that data source config was successful or not. This PR adds an expect matcher to assert that a certain alert box is present in the page.Which issue(s) this PR fixes:
Part of #576
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@0.0.3-canary.610.b925ceb.0 # or yarn add @grafana/plugin-e2e@0.0.3-canary.610.b925ceb.0