Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin-E2E: Keep comments in tsd files #614

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Plugin-E2E: Keep comments in tsd files #614

merged 1 commit into from
Dec 19, 2023

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Dec 19, 2023 •
edited
Loading

What this PR does / why we need it:

Most of the comments in this repo are written for package consumers. This PR makes sure comments are not stripped away from tsd files.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sunker sunker requested a review from a team as a code owner December 19, 2023 09:00
@sunker sunker requested review from academo and removed request for a team December 19, 2023 09:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker requested a review from jackw December 19, 2023 09:01
@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Dec 19, 2023
@sunker sunker changed the title Plugin-E2e: Keep comments in tsd files Plugin-E2E: Keep comments in tsd files Dec 19, 2023
@sunker sunker added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Dec 19, 2023
jackw
jackw approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sunker sunker merged commit c474354 into main Dec 19, 2023
23 of 24 checks passed
@sunker sunker deleted the plugin-e2e/keep-comments branch December 19, 2023 14:01
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.2.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunker @jackw