Plugin-E2E: Allow provisioningRootDir to be overridden #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
minor
academo
reviewed
Jan 2, 2024
| @@ -15,7 +15,19 @@ import { grafanaE2ESelectorEngine } from './selectorEngine'; | |||
| import { ExplorePage } from './models/ExplorePage'; | |||
|
|
|||
| export type PluginOptions = { | |||
| selectorRegistration: void; | |||
There was a problem hiding this comment.
is removing this from the type intentional?
There was a problem hiding this comment.
Good catch - should have added a GH comment about this. Yes, it was intentionally removed. It's not an actual fixture option, so it doesn't belong there.
academo
approved these changes
Jan 2, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using the
readProvisionfixture, provisioned files are read from a rootdir. For external plugins, this will most likely always be<projectRoot>/provisioning. However in some projects, you may want to specify an alternative directory for your provisioning files. For example, in core Grafana, you may want to usedevenv.This PR makes it possible to override the default directory for provisioning files. It can be done globally or on a project level in the playwright config, or in an individual test.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@0.3.0-canary.623.aedff75.0 # or yarn add @grafana/plugin-e2e@0.3.0-canary.623.aedff75.0