Plugin E2E: Fix isFeatureEnabled fixture #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
patch
sunker
requested review from
jackw and
academo
and removed request for
a team
sunker
commented
Jan 23, 2024
| @@ -24,6 +24,7 @@ const page: PageFixture = async ({ page, featureToggles }, use) => { | |||
| console.error('Failed to set feature toggles', error); | |||
| } | |||
| } | |||
| await page.goto('/'); | |||
There was a problem hiding this comment.
Load start page so that page init scripts is executed before other fixtures.
academo
approved these changes
Jan 23, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While adding support for substituting feature toggles during a test session, overrides were set in local storage (when Grafana version is => 10.1.0). I did not think about the fact that we have a fixture called
isFeatureEnabled. If overrides aren't propagated towindow.grafanaBootData.settings.featureToggles, there's no way for this fixture to know weather a FE feature is enabled or not. This PR ensures overrides are added directly towindow.grafanaBootData.settings.featureToggles, which will fix the brokenisFeatureEnabledfixture.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@0.10.1-canary.691.5a4661c.0 # or yarn add @grafana/plugin-e2e@0.10.1-canary.691.5a4661c.0