Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Add auth test file #700

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Plugin E2E: Add auth test file #700

merged 1 commit into from
Jan 29, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Jan 26, 2024

What this PR does / why we need it:

This PR adds an auth test that login to Grafana and stores the response cookie on disk. For every consumer of this package, this needs to be done in a Playwright setup project, so letting them point to this test rather than creating the file themselves within their plugin code simplifies things a lot.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@0.10.4-canary.700.e9c6ce3.0
# or 
yarn add @grafana/plugin-e2e@0.10.4-canary.700.e9c6ce3.0

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker changed the title [POC] Plugin E2e: Add auth test file Plugin E2e: Add auth test file Jan 26, 2024
@sunker sunker marked this pull request as ready for review January 26, 2024 12:21
@sunker sunker requested a review from a team as a code owner January 26, 2024 12:21
@sunker sunker requested review from academo and removed request for a team January 26, 2024 12:21
@sunker sunker changed the title Plugin E2e: Add auth test file Plugin E2E: Add auth test file Jan 26, 2024
@sunker sunker requested a review from jackw January 26, 2024 12:21
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

How would they point to this test in their projects? Would it make sense to add some docs on this?

@sunker
Copy link
Contributor Author

sunker commented Jan 29, 2024

LGTM 👍

How would they point to this test in their projects? Would it make sense to add some docs on this?

Yes! I'm working on a Getting started docs for plugin-e2e. Will put up at draft PR later today that walks through exactly this. :)

@sunker sunker merged commit 18c5110 into main Jan 29, 2024
25 of 27 checks passed
@sunker sunker deleted the plugin-e2e/include-auth-file branch January 29, 2024 10:24
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@3.1.3, @grafana/plugin-e2e@0.10.4 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants