Move to monorepo to introduce sign-plugin #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
enhancement
|
Love it! Go go go 🚀 |
mckn
reviewed
Oct 18, 2022
|
|
I like the idea as well! 🚀 |
jackw
force-pushed
the
jackw/introduce-plugin-sign
branch
from
45b2b9c
to
a875274
Compare
It was already in the repo but looking at the docs it doesn't appear to be referenced anywhere. I'm thinking we can 🔪 it. WDYT @mckn ? |
jackw
changed the title
go go go 🔥 |
leventebalogh
approved these changes
Oct 19, 2022
| In your plugin directory, run the following to create a MANIFEST.txt file in the dist directory of your plugin. | ||
|
|
||
| ```bash | ||
| npx @grafana/sign-plugin --rootUrls https://example.com/grafana |
There was a problem hiding this comment.
Not something necessarily for now: maybe it could be good to add some explanation on what the --rootUrls flag is exactly and how they should use it? (I don't think it's straightforward for everyone by the first sight.)
…in tests from toolkit
jackw
force-pushed
the
jackw/introduce-plugin-sign
branch
from
38a36b8
to
38e4097
Compare
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a starting point to move plugin signing out of toolkit and into its own package. Currently we have a workflow in create-plugin that includes signing a plugin. This has a dependency on toolkit which I'm keen to remove before we launch create-plugin@v1.0.0.
Consensus is needed on the following points for us to move forward with this PR:(Based on discussions and comments in the PR consensus seems to be this is a good direction.)Alternatively we take the contents of sign-plugin in this PR and put it in its own repo.Notes for reviewers
I've lifted most of the signing code from toolkit into this repo. I haven't made any changes other than removing the dependency on grafana/data and setting the toolkit version to an empty string just to get it working. I'm thinking we can clean all this up iteratively.
Follow Up Tasks
grafana/plugin-toolscreate-plugintoplugin-tools