Plugin E2E: Fix APIs that are broken in older versions of Grafana #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
force-pushed
the
plugin-e2e/fix-bugs-in-older-g-versions
branch
from
f1d972c
to
f834810
Compare
sunker
added
patch
sunker
force-pushed
the
plugin-e2e/fix-bugs-in-older-g-versions
branch
from
f834810
to
9e7f7b8
Compare
sunker
changed the title
sunker
changed the title
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the docs we indicate that all plugin-e2e apis are compatible with Grafana 8.5 and onwards. However, the workflow that runs playwright tests in this repo only tests against Grafana 9.5 an onwards. While testing against older versions of Grafana locally, I noticed a few bugs/broken scenarios that are now fixed in this PR.
Ideally, the repo should run tests against every version of Grafana that we have committed to support. However, that would start up around 15 jobs per PR which is not ideal. Maybe we can define another workflow that runs nighlt tests against all these versions sequentially?
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.5.0-canary.739.5d6b944.0 npm install @grafana/plugin-e2e@0.27.0-canary.739.5d6b944.0 # or yarn add @grafana/create-plugin@4.5.0-canary.739.5d6b944.0 yarn add @grafana/plugin-e2e@0.27.0-canary.739.5d6b944.0