Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use TS_NODE_PROJECT for webpack configuration #75

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

academo
Copy link
Member

@academo academo commented Oct 19, 2022

Fixes #71

Instead of using an environment variable it uses an overwrite in the tsconfig for ts-node (which transpiles the webpack config).

the transpiler ts-node/transpilers/swc-experimental was removed from the config as it was creating problems with ts-node and it is a minimal optimization in speed for this specific case.

With these changes the generated scripts run natively in windows.

image

@academo academo added the bug label Oct 19, 2022
@academo academo self-assigned this Oct 19, 2022
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this @academo ! 🚀

@academo academo merged commit cdaa9d0 into main Oct 19, 2022
@academo academo deleted the fix-windows-webpack-run branch October 19, 2022 11:08
@wz2b
Copy link

wz2b commented Oct 19, 2022

I tested this using npx @grafana/create-plugin@0.2.1 update and it worked perfectly. I didn't have to touch any of my own sources, and the plugin builds the same on windows and linux now (tested both). Thanks for the effort on this, and especially for fixing it so quickly - I really appreciate not having to wedge in temporary hacks while waiting for this to be fixed. I'm astonished and happy as a clam at how quickly you were able to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Migrate: Env vars break in Windows
3 participants