Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin-e2e: Add yaml as a dependency #755

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Plugin-e2e: Add yaml as a dependency #755

merged 1 commit into from
Feb 19, 2024

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Feb 19, 2024

What this PR does / why we need it:

Currently when importing plugin-e2e an error appears complaining that the yaml package isn't available. This is due to it not being a direct dependency of the project.

image

The PR adds it as a dependency.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw added patch Increment the patch version when merged plugin-e2e related to the plugin-e2e package labels Feb 19, 2024
@jackw jackw self-assigned this Feb 19, 2024
@jackw jackw requested a review from a team as a code owner February 19, 2024 11:38
@jackw jackw requested review from Ukochka and sunker and removed request for a team February 19, 2024 11:38
Copy link

github-actions bot commented Feb 19, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jackw jackw added the release Create a release when this pr is merged label Feb 19, 2024
@jackw jackw merged commit 0b4f692 into main Feb 19, 2024
25 checks passed
@jackw jackw deleted the jackw/fix-e2e-deps branch February 19, 2024 12:55
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.17.1 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged plugin-e2e related to the plugin-e2e package release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants