Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: allow resolving json modules in TypeScript #8

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Feat: allow resolving json modules in TypeScript #8

merged 1 commit into from
Feb 18, 2022

Conversation

leventebalogh
Copy link
Collaborator

What changed?

Added the resolveJsonModule: true to the tsconfig.json to be able to import json modules, e.g. the plugin.json in scaffolded plugins.

@leventebalogh leventebalogh added the enhancement New feature or request label Feb 17, 2022
@leventebalogh leventebalogh self-assigned this Feb 17, 2022
mckn
mckn approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jackw
jackw approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff! 🚀

@leventebalogh leventebalogh merged commit f5e2a2a into main Feb 18, 2022
@leventebalogh leventebalogh deleted the leventebalogh/resolve-json-modules branch February 18, 2022 08:12
@renovate renovate bot mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@mckn mckn mckn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leventebalogh @jackw @mckn