Docs: Update docs for monorepo changes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
commented
Oct 20, 2022
| **Environment**: | ||
|
|
||
| <!-- | ||
| Please run `npx envinfo --system --binaries --browsers --npmPackages="@grafana/*"` where you are experiencing the bug and paste the results here. |
There was a problem hiding this comment.
The command mentioned here will output the following:
System:
OS: macOS 12.6
CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
Memory: 76.14 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.17.1 - ~/.nvm/versions/node/v16.17.1/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.15.0 - ~/.nvm/versions/node/v16.17.1/bin/npm
Browsers:
Chrome: 106.0.5249.119
Firefox: 104.0.2
Safari: 16.0
npmPackages:
@grafana/data: latest => 9.2.0
@grafana/toolkit: latest => 9.2.0
@grafana/ui: latest => 9.2.0
academo
reviewed
Oct 20, 2022
| @@ -0,0 +1,25 @@ | |||
| --- | |||
| name: Bug report | |||
| about: Report a bug you found | |||
There was a problem hiding this comment.
Given this is a mono-repo. We can add a field for project or package name. e.g.: create-plugin, sign-plugin and other upcoming tools.
There was a problem hiding this comment.
I've migrated to using github forms for this issue template.
academo
reviewed
Oct 20, 2022
| @@ -1,42 +1,149 @@ | |||
| # Contributing to Grafana / Create Plugin | |||
| # Contributing | |||
There was a problem hiding this comment.
We should include something about the CLA here.
|
This is great! thanks for updating all these docs and adding even more. Only one question, do we also need to update the repository field in the several package.json? Line 4 in d3dda73 |
academo
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: