Plugin E2E: Rename getByTestIdOrAriaLabel to getByGrafanaSelector #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
changed the title
sunker
added
minor
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces deprecates the
getByTestIdOrAriaLabeland introduces agetByGrafanaSelectormethod instead. ThegetByGrafanaSelectormethod works in the same way as thegetByTestIdOrAriaLabelmethod - it's just a name change to make its purpose a bit more clear. ThegetByGrafanaSelectoris marked as deprecated, but will still work until we release 1.0.0 of the plugn-e2e package.Which issue(s) this PR fixes:
Fixes #825
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.5.0-canary.832.708efb9.0 npm install @grafana/plugin-e2e@0.25.0-canary.832.708efb9.0 # or yarn add @grafana/create-plugin@4.5.0-canary.832.708efb9.0 yarn add @grafana/plugin-e2e@0.25.0-canary.832.708efb9.0