Build: Introduce stricter typechecking #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
patch
jackw
requested review from
leventebalogh and
sunker
and removed request for
a team
academo
approved these changes
Apr 15, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Noticed that after the move to using
tsconfigbase configs that we're lacking some useful typescript compiler options to keep our code cleaner. Namely:which prevent unused variables and params which I find somewhat confusing when scanning code.
This PR adds a selection of the strictest options to this codebase with the intention that we can eventually use that config to keep our code in a more healthy state.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.6.2-canary.868.05615c5.0 npm install @grafana/plugin-e2e@1.1.1-canary.868.05615c5.0 # or yarn add @grafana/create-plugin@4.6.2-canary.868.05615c5.0 yarn add @grafana/plugin-e2e@1.1.1-canary.868.05615c5.0