Skip to content

Mixin Lint fixes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Mixin Lint fixes #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0448574
lint fixes
gaantunes Aug 2, 2023
20898ac
Add .lint exclusion file - for mixtool
gaantunes Aug 2, 2023
43a7ddf
Update .lint exclusion file - for mixtool
gaantunes Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions postgres_mixin/.lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
exclusions:
panel-units-rule:
reason: Ignoring so far, need to address this in future
panel-title-description-rule:
reason: Ignoring so far, need to address this in future
panel-datasource-rule:
reason: "Loki datasource variable is being named as loki_datasource now while linter expects 'datasource'"
template-datasource-rule:
reason: "Based on new convention we are using variable names prometheus_datasource and loki_datasource where as linter expects 'datasource'"
alert-name-camelcase:
reason: QPS is a common acronym (Queries Per Second) and should be allowed
entries:
- alert: PostgreSQLQPS

6 changes: 3 additions & 3 deletions postgres_mixin/dashboards/postgres-overview.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,7 @@
"query": "label_values(pg_up, job)",
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
"regex": "",
"skipUrlSync": false,
"sort": 0,
Expand Down Expand Up @@ -1372,7 +1372,7 @@
"query": "label_values(pg_up{job=~\"$job\"},instance)",
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
"regex": "",
"skipUrlSync": false,
"sort": 0,
Expand All @@ -1397,7 +1397,7 @@
"query": "label_values(pg_stat_database_tup_fetched{%(postgresExporterSelector)s,datname!~\"template.*|postgres\"},datname)" % $._config,
"refId": "StandardVariableQuery"
},
"refresh": 1,
"refresh": 2,
"regex": "",
"skipUrlSync": false,
"sort": 0,
Expand Down