Fix dropped samples metric

Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
grafana · Jan 5, 2024 · 43cadd5 · 43cadd5
1 parent 3e2c486
commit 43cadd5
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/storage/remote/queue_manager.go b/storage/remote/queue_manager.go
@@ -634,7 +634,6 @@ outer:
  t.seriesMtx.Lock()
  lbls, ok := t.seriesLabels[s.Ref]
  if !ok {
- t.metrics.droppedSamplesTotal.WithLabelValues(reasonDroppedSeries).Inc()
  t.dataDropped.incr(1)
  if _, ok := t.droppedSeries[s.Ref]; !ok {
  level.Info(t.logger).Log("msg", "Dropped sample for series that was not explicitly dropped via relabelling", "ref", s.Ref)
@@ -803,8 +802,8 @@ outer:
  if !ok {
  t.dataDropped.incr(1)
  if _, ok := t.droppedSeries[h.Ref]; !ok {
- t.metrics.droppedHistogramsTotal.WithLabelValues(reasonUnintentionalDroppedSeries).Inc()
  level.Info(t.logger).Log("msg", "Dropped histogram for series that was not explicitly dropped via relabelling", "ref", h.Ref)
+ t.metrics.droppedHistogramsTotal.WithLabelValues(reasonUnintentionalDroppedSeries).Inc()
  } else {
  t.metrics.droppedHistogramsTotal.WithLabelValues(reasonDroppedSeries).Inc()
  }